Feature | Extend Swagger Coverage for controller OAuth2SummitBadgeScanApiController #458
+456
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrestejerina97
force-pushed
the
feature/add-sponsor-badge-scan-swagger
branch
from
3f8cc59 to
189390c
Compare
caseylocker
requested changes
Dec 2, 2025
There was a problem hiding this comment.
Security schemas namespace needs updating.
Needs to use namespace App\Swagger\schemas; per standard.
Theres a missing scope in the authschema.
Add SummitScopes::WriteMyBadgeScan => 'Write My Badge Scan Data'
And since there are changes lets go ahead and make sure that our tags are sticking to the Title Case format.
Current: tags: ["BadgeScans"], tags: ["SponsorUserInfoGrants"]
Expected: tags: ["Badge Scans"], tags: ["Sponsor User Info Grants"]
Also add operationId where needed.
matiasperrone-exo
changed the title
matiasperrone-exo
added
the
documentation
matiasperrone-exo
assigned
andrestejerina97 and
matiasperrone-exo and unassigned
andrestejerina97
matiasperrone-exo
force-pushed
the
feature/add-sponsor-badge-scan-swagger
branch
from
189390c to
9f70bcb
Compare
smarcet
force-pushed
the
main
branch
4 times, most recently
from
c6ecdd0 to
728ae67
Compare
matiasperrone-exo
force-pushed
the
feature/add-sponsor-badge-scan-swagger
branch
2 times, most recently
from
1b3670c to
8d78937
Compare
…troller::getAddValidationRules(), 0 passed Signed-off-by: Matias Perrone <github@matiasperrone.com>
Signed-off-by: Matias Perrone <github@matiasperrone.com>
matiasperrone-exo
force-pushed
the
feature/add-sponsor-badge-scan-swagger
branch
from
8d78937 to
3dcee97
Compare
Signed-off-by: Matias Perrone <github@matiasperrone.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86b6wkh5y